From 60c5d41161f4991c1a7d5a58fe06d17c1acb6994 Mon Sep 17 00:00:00 2001 From: Jan Klattenhoff Date: Wed, 22 Jan 2025 12:11:04 +0100 Subject: [PATCH 1/2] fix(mitarbeiter-form): prevent adding skill with invalid id --- .../components/mitarbeiter-form/mitarbeiter-form.component.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/app/components/mitarbeiter-form/mitarbeiter-form.component.ts b/src/app/components/mitarbeiter-form/mitarbeiter-form.component.ts index 215be8f..d2e7a90 100644 --- a/src/app/components/mitarbeiter-form/mitarbeiter-form.component.ts +++ b/src/app/components/mitarbeiter-form/mitarbeiter-form.component.ts @@ -82,6 +82,9 @@ export class MitarbeiterFormComponent { addSkill() { const id = Number(this.mitarbeiterForm.get("newSkill")?.value); + if (!id) { + return; + } this.allSkills.subscribe(skills => { const newSkill = skills.filter(skill => skill.id == id)[0]; this.mitarbeiter.skillSet?.push(newSkill); From 2e9b48be7ca7277319721a87b95de766ca8b2dd2 Mon Sep 17 00:00:00 2001 From: Jan Klattenhoff Date: Wed, 22 Jan 2025 12:12:11 +0100 Subject: [PATCH 2/2] fix(qualifikation-form): prevent adding invalid employee ID --- .../qualifikation-form/qualifikation-form.component.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/app/components/qualifikation-form/qualifikation-form.component.ts b/src/app/components/qualifikation-form/qualifikation-form.component.ts index aad7492..03c1353 100644 --- a/src/app/components/qualifikation-form/qualifikation-form.component.ts +++ b/src/app/components/qualifikation-form/qualifikation-form.component.ts @@ -55,6 +55,9 @@ export class QualifikationFormComponent { addEmployee() { const employeeId = Number(this.skillForm.get("newEmployee")?.value); + if (!employeeId) { + return; + } const employee = this.addableEmployees.find(emp => emp.id === employeeId); if (employee) {