jank/LF8
2
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases 13 Wiki Activity

refactor: simplify project deletion logic in action class
Some checks failed
Quality Check / Tests (pull_request) Successful in 1m3s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 46s
Details
gitea-sonarqube-bot ERROR
Details
Build PR / Build and analyze (pull_request) Successful in 1m59s
Details

Browse Source
This commit is contained in:
Jan Gleytenhoover 2024-10-02 11:27:25 +02:00
parent 4abce554e5
commit 4c44b843ae
Signed by: jank
GPG Key ID: B267751B8AE29EFE
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/main/java/de/szut/lf8_starter/project/action/RemoveProjectAction.java
View File

@ -33,12 +33,11 @@ public class RemoveProjectAction {
@DeleteMapping("/{id}") @DeleteMapping("/{id}")
public ResponseEntity<GetProjectDto> findArticleById(@PathVariable Long id) { public ResponseEntity<GetProjectDto> findArticleById(@PathVariable Long id) {
Optional<ProjectEntity> project = this.projectService.findById(id); Optional<ProjectEntity> project = this.projectService.findById(id);
if (project.isEmpty()) { if (project.isEmpty()) {
return new ResponseEntity<>(HttpStatus.NOT_FOUND); return new ResponseEntity<>(HttpStatus.NOT_FOUND);
} }
this.projectService.delete(project.get().getId()); this.projectService.delete(id);
return new ResponseEntity<>(HttpStatus.NO_CONTENT); return new ResponseEntity<>(HttpStatus.NO_CONTENT);
} }
} }

3
src/test/java/de/szut/lf8_starter/integration/project/DeleteProjectActionTest.java
View File

@ -26,7 +26,6 @@ public class DeleteProjectActionTest {
@Test @Test
void deleteProjectTest() throws Exception { void deleteProjectTest() throws Exception {
var project = new ProjectEntity(); var project = new ProjectEntity();
project.setId(20);
project.setComment("comment"); project.setComment("comment");
project.setContractor(1); project.setContractor(1);
project.setContractorName("contractorName"); project.setContractorName("contractorName");
@ -37,7 +36,7 @@ public class DeleteProjectActionTest {
project.setEmployees(List.of(1L, 2L, 3L)); project.setEmployees(List.of(1L, 2L, 3L));
this.projectRepository.save(project); this.projectRepository.save(project);
this.mockMvc.perform(delete("/projects/20")) this.mockMvc.perform(delete("/projects/" + project.getId()))
.andExpect(status().isNoContent()); .andExpect(status().isNoContent());
} }