actions/setup-java
2
0
Fork 0
mirror of https://github.com/actions/setup-java.git synced 2025-04-20 09:56:46 +00:00
Code Issues Projects Releases Packages Wiki Activity

minor refactoring

Browse source
This commit is contained in:
Maxim Lobanov 2021-03-08 18:31:01 +03:00
parent cfdcd6827b
commit 1d25bcb6a7
6 changed files with 49 additions and 114 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/distributions/base-installer.ts
View file

@ -60,7 +60,7 @@ export abstract class JavaBase {
}
protected findInToolcache(): JavaInstallerResults | null {
// we can't use tc.find directly because firstly, we need to filter versions by stability
// we can't use tc.find directly because firstly, we need to filter versions by stability flag
// if *-ea is provided, take only ea versions from toolcache, otherwise - only stable versions
const availableVersions = tc
.findAllVersions(this.toolcacheFolderName, this.architecture)
@ -97,7 +97,7 @@ export abstract class JavaBase {
let stable = true;
if (version.endsWith('-ea')) {
version = version.replace('-ea', '');
version = version.replace(/-ea$/, '');
stable = false;
}

4
src/distributions/local/installer.ts
View file

@ -69,10 +69,10 @@ export class LocalDistribution extends JavaBase {
}
protected async findPackageForDownload(version: semver.Range): Promise<JavaDownloadRelease> {
throw new Error('Should not be implemented');
throw new Error('This method should not be implemented in local file provider');
}
protected async downloadTool(javaRelease: JavaDownloadRelease): Promise<JavaInstallerResults> {
throw new Error('Should not be implemented');
throw new Error('This method should not be implemented in local file provider');
}
}