mirror of
				https://github.com/docker/setup-buildx-action.git
				synced 2025-11-03 23:40:53 +00:00 
			
		
		
		
	Merge pull request #366 from crazy-max/remove-uuid
remove uuid package and switch to crypto
This commit is contained in:
		
				commit
				
					
						910a304005
					
				
			
		
					 7 changed files with 9 additions and 33 deletions
				
			
		| 
						 | 
				
			
			@ -1,7 +1,6 @@
 | 
			
		|||
import {beforeEach, describe, expect, jest, test} from '@jest/globals';
 | 
			
		||||
import * as fs from 'fs';
 | 
			
		||||
import * as path from 'path';
 | 
			
		||||
import * as uuid from 'uuid';
 | 
			
		||||
import {Buildx} from '@docker/actions-toolkit/lib/buildx/buildx';
 | 
			
		||||
import {Context} from '@docker/actions-toolkit/lib/context';
 | 
			
		||||
import {Docker} from '@docker/actions-toolkit/lib/docker/docker';
 | 
			
		||||
| 
						 | 
				
			
			@ -26,8 +25,7 @@ jest.spyOn(Context, 'tmpName').mockImplementation((): string => {
 | 
			
		|||
  return tmpName;
 | 
			
		||||
});
 | 
			
		||||
 | 
			
		||||
jest.mock('uuid');
 | 
			
		||||
jest.spyOn(uuid, 'v4').mockReturnValue('9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d');
 | 
			
		||||
jest.spyOn(crypto, 'randomUUID').mockReturnValue('9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d');
 | 
			
		||||
 | 
			
		||||
jest.spyOn(Docker, 'context').mockImplementation((): Promise<string> => {
 | 
			
		||||
  return Promise.resolve('default');
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
							
								
								
									
										6
									
								
								dist/index.js
									
										
									
										generated
									
									
										vendored
									
									
								
							
							
						
						
									
										6
									
								
								dist/index.js
									
										
									
										generated
									
									
										vendored
									
									
								
							
										
											
												File diff suppressed because one or more lines are too long
											
										
									
								
							
							
								
								
									
										2
									
								
								dist/index.js.map
									
										
									
										generated
									
									
										vendored
									
									
								
							
							
						
						
									
										2
									
								
								dist/index.js.map
									
										
									
										generated
									
									
										vendored
									
									
								
							
										
											
												File diff suppressed because one or more lines are too long
											
										
									
								
							| 
						 | 
				
			
			@ -27,13 +27,11 @@
 | 
			
		|||
  "dependencies": {
 | 
			
		||||
    "@actions/core": "^1.10.1",
 | 
			
		||||
    "@docker/actions-toolkit": "^0.35.0",
 | 
			
		||||
    "js-yaml": "^4.1.0",
 | 
			
		||||
    "uuid": "^10.0.0"
 | 
			
		||||
    "js-yaml": "^4.1.0"
 | 
			
		||||
  },
 | 
			
		||||
  "devDependencies": {
 | 
			
		||||
    "@types/js-yaml": "^4.0.9",
 | 
			
		||||
    "@types/node": "^20.12.12",
 | 
			
		||||
    "@types/uuid": "^10.0.0",
 | 
			
		||||
    "@typescript-eslint/eslint-plugin": "^7.9.0",
 | 
			
		||||
    "@typescript-eslint/parser": "^7.9.0",
 | 
			
		||||
    "@vercel/ncc": "^0.38.1",
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -1,4 +1,3 @@
 | 
			
		|||
import * as uuid from 'uuid';
 | 
			
		||||
import * as core from '@actions/core';
 | 
			
		||||
 | 
			
		||||
import {Docker} from '@docker/actions-toolkit/lib/docker/docker';
 | 
			
		||||
| 
						 | 
				
			
			@ -47,7 +46,7 @@ export async function getInputs(): Promise<Inputs> {
 | 
			
		|||
}
 | 
			
		||||
 | 
			
		||||
export async function getBuilderName(driver: string): Promise<string> {
 | 
			
		||||
  return driver == 'docker' ? await Docker.context() : `builder-${uuid.v4()}`;
 | 
			
		||||
  return driver == 'docker' ? await Docker.context() : `builder-${crypto.randomUUID()}`;
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
export async function getCreateArgs(inputs: Inputs, toolkit: Toolkit): Promise<Array<string>> {
 | 
			
		||||
| 
						 | 
				
			
			@ -84,7 +83,7 @@ export async function getAppendArgs(inputs: Inputs, node: Node, toolkit: Toolkit
 | 
			
		|||
  if (node.name) {
 | 
			
		||||
    args.push('--node', node.name);
 | 
			
		||||
  } else if (inputs.driver == 'kubernetes' && (await toolkit.buildx.versionSatisfies('<0.11.0'))) {
 | 
			
		||||
    args.push('--node', `node-${uuid.v4()}`);
 | 
			
		||||
    args.push('--node', `node-${crypto.randomUUID()}`);
 | 
			
		||||
  }
 | 
			
		||||
  if (node['driver-opts'] && (await toolkit.buildx.versionSatisfies('>=0.3.0'))) {
 | 
			
		||||
    await Util.asyncForEach(node['driver-opts'], async (driverOpt: string) => {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -1,6 +1,5 @@
 | 
			
		|||
import * as fs from 'fs';
 | 
			
		||||
import * as yaml from 'js-yaml';
 | 
			
		||||
import * as uuid from 'uuid';
 | 
			
		||||
import * as core from '@actions/core';
 | 
			
		||||
import * as actionsToolkit from '@docker/actions-toolkit';
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -98,7 +97,7 @@ actionsToolkit.run(
 | 
			
		|||
        });
 | 
			
		||||
      });
 | 
			
		||||
      if (defaultContextWithTLS) {
 | 
			
		||||
        const tmpDockerContext = `buildx-${uuid.v4()}`;
 | 
			
		||||
        const tmpDockerContext = `buildx-${crypto.randomUUID()}`;
 | 
			
		||||
        await core.group(`Creating temp docker context (TLS data loaded in default one)`, async () => {
 | 
			
		||||
          await Docker.getExecOutput(['context', 'create', tmpDockerContext], {
 | 
			
		||||
            ignoreReturnCode: true
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
							
								
								
									
										18
									
								
								yarn.lock
									
										
									
									
									
								
							
							
						
						
									
										18
									
								
								yarn.lock
									
										
									
									
									
								
							| 
						 | 
				
			
			@ -2124,13 +2124,6 @@ __metadata:
 | 
			
		|||
  languageName: node
 | 
			
		||||
  linkType: hard
 | 
			
		||||
 | 
			
		||||
"@types/uuid@npm:^10.0.0":
 | 
			
		||||
  version: 10.0.0
 | 
			
		||||
  resolution: "@types/uuid@npm:10.0.0"
 | 
			
		||||
  checksum: e3958f8b0fe551c86c14431f5940c3470127293280830684154b91dc7eb3514aeb79fe3216968833cf79d4d1c67f580f054b5be2cd562bebf4f728913e73e944
 | 
			
		||||
  languageName: node
 | 
			
		||||
  linkType: hard
 | 
			
		||||
 | 
			
		||||
"@types/yargs-parser@npm:*":
 | 
			
		||||
  version: 20.2.0
 | 
			
		||||
  resolution: "@types/yargs-parser@npm:20.2.0"
 | 
			
		||||
| 
						 | 
				
			
			@ -3171,7 +3164,6 @@ __metadata:
 | 
			
		|||
    "@docker/actions-toolkit": ^0.35.0
 | 
			
		||||
    "@types/js-yaml": ^4.0.9
 | 
			
		||||
    "@types/node": ^20.12.12
 | 
			
		||||
    "@types/uuid": ^10.0.0
 | 
			
		||||
    "@typescript-eslint/eslint-plugin": ^7.9.0
 | 
			
		||||
    "@typescript-eslint/parser": ^7.9.0
 | 
			
		||||
    "@vercel/ncc": ^0.38.1
 | 
			
		||||
| 
						 | 
				
			
			@ -3185,7 +3177,6 @@ __metadata:
 | 
			
		|||
    ts-jest: ^29.1.2
 | 
			
		||||
    ts-node: ^10.9.2
 | 
			
		||||
    typescript: ^5.4.5
 | 
			
		||||
    uuid: ^10.0.0
 | 
			
		||||
  languageName: unknown
 | 
			
		||||
  linkType: soft
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -6670,15 +6661,6 @@ __metadata:
 | 
			
		|||
  languageName: node
 | 
			
		||||
  linkType: hard
 | 
			
		||||
 | 
			
		||||
"uuid@npm:^10.0.0":
 | 
			
		||||
  version: 10.0.0
 | 
			
		||||
  resolution: "uuid@npm:10.0.0"
 | 
			
		||||
  bin:
 | 
			
		||||
    uuid: dist/bin/uuid
 | 
			
		||||
  checksum: 4b81611ade2885d2313ddd8dc865d93d8dccc13ddf901745edca8f86d99bc46d7a330d678e7532e7ebf93ce616679fb19b2e3568873ac0c14c999032acb25869
 | 
			
		||||
  languageName: node
 | 
			
		||||
  linkType: hard
 | 
			
		||||
 | 
			
		||||
"uuid@npm:^3.3.2, uuid@npm:^3.3.3":
 | 
			
		||||
  version: 3.4.0
 | 
			
		||||
  resolution: "uuid@npm:3.4.0"
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue