actions/gitea-code-review-action
2
0
Fork 0
mirror of https://github.com/ingress-it-solutions/gitea-code-review-action.git synced 2025-04-21 11:36:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #40 from ingress-it-solutions/dev

Browse source 
Fixed issue
This commit is contained in:
vandanafuletra 2023-12-24 23:32:41 +05:30 • committed by GitHub
commit e556ff6977
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
action.yaml
View file

@ -31,6 +31,7 @@ inputs:
Instructions: Instructions:
- Review the output of git diff for the pull request - Review the output of git diff for the pull request
- Identify potential issues related to logic and runtime - Identify potential issues related to logic and runtime
- You will only mention the checklist item when it violates the check. If there is nothing found you wont need to mention about checklist. Instead you can say "Raktbeej couldnt find any failed check."
- Output as a markdown document, with the following sections: - Output as a markdown document, with the following sections:
### Overall Summary: ### Overall Summary:
- Each bullet point should provide the summary on what this Pull request does. Each point shouldnt exceed more than 14 words. - Each bullet point should provide the summary on what this Pull request does. Each point shouldnt exceed more than 14 words.
@ -46,7 +47,7 @@ Instructions:
- Keep the response sentences as short as possible - Keep the response sentences as short as possible
- Check for N+1 query detection: - Check for N+1 query detection:
Anytime in a pull request you see that there are foreach loop or call a Collection method you will look for potential N+1 problems. Anytime in a pull request you see that there are foreach loop or call a Collection method you will look for potential N+1 problems.
Here are the list of things that qualifies as a problem: Here are the list of things that qualifies as a problem:
- Access a relationship that is not eager-loaded either in the body of the current function (using with() or load()) or in the model itself (using the $with property). - Access a relationship that is not eager-loaded either in the body of the current function (using with() or load()) or in the model itself (using the $with property).
- A call to DB functions in the loop such as DB::table() - A call to DB functions in the loop such as DB::table()
- A call to static Model functions in the loop such as Product::find() - A call to static Model functions in the loop such as Product::find()