mirror of
https://github.com/freeedcom/ai-codereviewer.git
synced 2025-04-19 17:16:48 +00:00
Added tests, debug logging and fix max tokens bug
This commit is contained in:
parent
c1c54576e4
commit
7027b3ba7b
5 changed files with 165 additions and 44 deletions
2
.github/workflows/code_review.yml
vendored
2
.github/workflows/code_review.yml
vendored
|
@ -12,7 +12,7 @@ jobs:
|
|||
- name: Checkout repository
|
||||
uses: actions/checkout@v3
|
||||
- name: Code Review
|
||||
uses: researchwiseai/ai-codereviewer@moving-to-o1
|
||||
uses: researchwiseai/ai-codereviewer@main
|
||||
with:
|
||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY_V2 }}
|
||||
|
|
74
dist/index.js
vendored
74
dist/index.js
vendored
|
@ -101,6 +101,7 @@ require("./sourcemap-register.js");
|
|||
function (mod) {
|
||||
return mod && mod.__esModule ? mod : { default: mod };
|
||||
};
|
||||
var _a, _b, _c, _d;
|
||||
Object.defineProperty(exports, "__esModule", { value: true });
|
||||
const fs_1 = __nccwpck_require__(7147);
|
||||
const core = __importStar(__nccwpck_require__(2186));
|
||||
|
@ -108,9 +109,18 @@ require("./sourcemap-register.js");
|
|||
const rest_1 = __nccwpck_require__(5375);
|
||||
const parse_diff_1 = __importDefault(__nccwpck_require__(4833));
|
||||
const minimatch_1 = __importDefault(__nccwpck_require__(2002));
|
||||
const GITHUB_TOKEN = core.getInput("GITHUB_TOKEN");
|
||||
const OPENAI_API_KEY = core.getInput("OPENAI_API_KEY");
|
||||
const OPENAI_API_MODEL = core.getInput("OPENAI_API_MODEL");
|
||||
const GITHUB_TOKEN =
|
||||
(_a = process.env.GITHUB_TOKEN) !== null && _a !== void 0
|
||||
? _a
|
||||
: core.getInput("GITHUB_TOKEN");
|
||||
const OPENAI_API_KEY =
|
||||
(_b = process.env.OPENAI_API_KEY) !== null && _b !== void 0
|
||||
? _b
|
||||
: core.getInput("OPENAI_API_KEY");
|
||||
const OPENAI_API_MODEL =
|
||||
(_c = process.env.OPENAI_API_MODEL) !== null && _c !== void 0
|
||||
? _c
|
||||
: core.getInput("OPENAI_API_MODEL");
|
||||
const octokit = new rest_1.Octokit({ auth: GITHUB_TOKEN });
|
||||
const openai = new openai_1.default({
|
||||
apiKey: OPENAI_API_KEY,
|
||||
|
@ -149,14 +159,16 @@ require("./sourcemap-register.js");
|
|||
return response.data;
|
||||
});
|
||||
}
|
||||
function analyzeCode(parsedDiff, prDetails) {
|
||||
function analyzeCode(parsedDiff, prDetails, verbose = false) {
|
||||
return __awaiter(this, void 0, void 0, function* () {
|
||||
const comments = [];
|
||||
for (const file of parsedDiff) {
|
||||
if (file.to === "/dev/null") continue; // Ignore deleted files
|
||||
for (const chunk of file.chunks) {
|
||||
const prompt = createPrompt(file, chunk, prDetails);
|
||||
const aiResponse = yield getAIResponse(prompt);
|
||||
if (verbose) console.log("Prompt:", prompt);
|
||||
const aiResponse = yield getAIResponse(prompt, verbose);
|
||||
if (verbose) console.log("AI Response:", aiResponse);
|
||||
if (aiResponse) {
|
||||
const newComments = createComment(file, chunk, aiResponse);
|
||||
if (newComments) {
|
||||
|
@ -199,12 +211,11 @@ ${chunk.changes
|
|||
\`\`\`
|
||||
`;
|
||||
}
|
||||
function getAIResponse(prompt) {
|
||||
function getAIResponse(prompt, verbose = false) {
|
||||
var _a, _b;
|
||||
return __awaiter(this, void 0, void 0, function* () {
|
||||
const queryConfig = {
|
||||
model: OPENAI_API_MODEL,
|
||||
max_completion_tokens: 700,
|
||||
};
|
||||
try {
|
||||
const response = yield openai.chat.completions.create(
|
||||
|
@ -217,6 +228,7 @@ ${chunk.changes
|
|||
],
|
||||
})
|
||||
);
|
||||
if (verbose) console.log("Response:", response);
|
||||
const res =
|
||||
((_b =
|
||||
(_a = response.choices[0].message) === null || _a === void 0
|
||||
|
@ -249,19 +261,25 @@ ${chunk.changes
|
|||
}
|
||||
function createReviewComment(owner, repo, pull_number, comments) {
|
||||
return __awaiter(this, void 0, void 0, function* () {
|
||||
yield octokit.pulls.createReview({
|
||||
owner,
|
||||
repo,
|
||||
pull_number,
|
||||
comments,
|
||||
event: "COMMENT",
|
||||
});
|
||||
try {
|
||||
yield octokit.pulls.createReview({
|
||||
owner,
|
||||
repo,
|
||||
pull_number,
|
||||
comments,
|
||||
event: "COMMENT",
|
||||
});
|
||||
} catch (error) {
|
||||
console.error(error);
|
||||
throw error;
|
||||
}
|
||||
});
|
||||
}
|
||||
function main() {
|
||||
var _a;
|
||||
function main(verbose = false) {
|
||||
var _a, _b;
|
||||
return __awaiter(this, void 0, void 0, function* () {
|
||||
const prDetails = yield getPRDetails();
|
||||
if (verbose) console.log("PR Details:", prDetails);
|
||||
let diff;
|
||||
const eventData = JSON.parse(
|
||||
(0, fs_1.readFileSync)(
|
||||
|
@ -271,13 +289,16 @@ ${chunk.changes
|
|||
"utf8"
|
||||
)
|
||||
);
|
||||
if (verbose) console.log("Event Data:", eventData);
|
||||
if (eventData.action === "opened") {
|
||||
if (verbose) console.log('Event action is "opened"');
|
||||
diff = yield getDiff(
|
||||
prDetails.owner,
|
||||
prDetails.repo,
|
||||
prDetails.pull_number
|
||||
);
|
||||
} else if (eventData.action === "synchronize") {
|
||||
if (verbose) console.log('Event action is "synchronize"');
|
||||
const newBaseSha = eventData.before;
|
||||
const newHeadSha = eventData.after;
|
||||
const response = yield octokit.repos.compareCommits({
|
||||
|
@ -289,20 +310,27 @@ ${chunk.changes
|
|||
base: newBaseSha,
|
||||
head: newHeadSha,
|
||||
});
|
||||
if (verbose) console.log("Response:", response);
|
||||
diff = String(response.data);
|
||||
} else {
|
||||
console.log("Unsupported event:", process.env.GITHUB_EVENT_NAME);
|
||||
return;
|
||||
}
|
||||
if (verbose) console.log("Diff:", diff);
|
||||
if (!diff) {
|
||||
console.log("No diff found");
|
||||
return;
|
||||
}
|
||||
const parsedDiff = (0, parse_diff_1.default)(diff);
|
||||
const excludePatterns = core
|
||||
.getInput("exclude")
|
||||
if (verbose) console.log("Parsed Diff:", parsedDiff);
|
||||
const excludePatterns = (
|
||||
(_b = process.env.EXCLUDE) !== null && _b !== void 0
|
||||
? _b
|
||||
: core.getInput("exclude")
|
||||
)
|
||||
.split(",")
|
||||
.map((s) => s.trim());
|
||||
if (verbose) console.log("Exclude Patterns:", excludePatterns);
|
||||
const filteredDiff = parsedDiff.filter((file) => {
|
||||
return !excludePatterns.some((pattern) => {
|
||||
var _a;
|
||||
|
@ -312,7 +340,9 @@ ${chunk.changes
|
|||
);
|
||||
});
|
||||
});
|
||||
const comments = yield analyzeCode(filteredDiff, prDetails);
|
||||
if (verbose) console.log("Filtered Diff:", filteredDiff);
|
||||
const comments = yield analyzeCode(filteredDiff, prDetails, verbose);
|
||||
if (verbose) console.log("Comments:", comments);
|
||||
if (comments.length > 0) {
|
||||
yield createReviewComment(
|
||||
prDetails.owner,
|
||||
|
@ -323,7 +353,11 @@ ${chunk.changes
|
|||
}
|
||||
});
|
||||
}
|
||||
main().catch((error) => {
|
||||
main(
|
||||
((_d = process.env.VERBOSE) !== null && _d !== void 0
|
||||
? _d
|
||||
: core.getInput("VERBOSE")) === "true"
|
||||
).catch((error) => {
|
||||
console.error("Error:", error);
|
||||
process.exit(1);
|
||||
});
|
||||
|
|
2
dist/index.js.map
vendored
2
dist/index.js.map
vendored
File diff suppressed because one or more lines are too long
87
src/main.ts
87
src/main.ts
|
@ -5,9 +5,12 @@ import { Octokit } from "@octokit/rest";
|
|||
import parseDiff, { Chunk, File } from "parse-diff";
|
||||
import minimatch from "minimatch";
|
||||
|
||||
const GITHUB_TOKEN: string = core.getInput("GITHUB_TOKEN");
|
||||
const OPENAI_API_KEY: string = core.getInput("OPENAI_API_KEY");
|
||||
const OPENAI_API_MODEL: string = core.getInput("OPENAI_API_MODEL");
|
||||
const GITHUB_TOKEN: string =
|
||||
process.env.GITHUB_TOKEN ?? core.getInput("GITHUB_TOKEN");
|
||||
const OPENAI_API_KEY: string =
|
||||
process.env.OPENAI_API_KEY ?? core.getInput("OPENAI_API_KEY");
|
||||
const OPENAI_API_MODEL: string =
|
||||
process.env.OPENAI_API_MODEL ?? core.getInput("OPENAI_API_MODEL");
|
||||
|
||||
const octokit = new Octokit({ auth: GITHUB_TOKEN });
|
||||
|
||||
|
@ -58,7 +61,8 @@ async function getDiff(
|
|||
|
||||
async function analyzeCode(
|
||||
parsedDiff: File[],
|
||||
prDetails: PRDetails
|
||||
prDetails: PRDetails,
|
||||
verbose = false
|
||||
): Promise<Array<{ body: string; path: string; line: number }>> {
|
||||
const comments: Array<{ body: string; path: string; line: number }> = [];
|
||||
|
||||
|
@ -66,7 +70,13 @@ async function analyzeCode(
|
|||
if (file.to === "/dev/null") continue; // Ignore deleted files
|
||||
for (const chunk of file.chunks) {
|
||||
const prompt = createPrompt(file, chunk, prDetails);
|
||||
const aiResponse = await getAIResponse(prompt);
|
||||
|
||||
if (verbose) console.log("Prompt:", prompt);
|
||||
|
||||
const aiResponse = await getAIResponse(prompt, verbose);
|
||||
|
||||
if (verbose) console.log("AI Response:", aiResponse);
|
||||
|
||||
if (aiResponse) {
|
||||
const newComments = createComment(file, chunk, aiResponse);
|
||||
if (newComments) {
|
||||
|
@ -110,13 +120,15 @@ ${chunk.changes
|
|||
`;
|
||||
}
|
||||
|
||||
async function getAIResponse(prompt: string): Promise<Array<{
|
||||
async function getAIResponse(
|
||||
prompt: string,
|
||||
verbose = false
|
||||
): Promise<Array<{
|
||||
lineNumber: string;
|
||||
reviewComment: string;
|
||||
}> | null> {
|
||||
const queryConfig = {
|
||||
model: OPENAI_API_MODEL,
|
||||
max_completion_tokens: 700,
|
||||
};
|
||||
|
||||
try {
|
||||
|
@ -130,6 +142,8 @@ async function getAIResponse(prompt: string): Promise<Array<{
|
|||
],
|
||||
});
|
||||
|
||||
if (verbose) console.log("Response:", response);
|
||||
|
||||
const res = response.choices[0].message?.content?.trim() || "{}";
|
||||
// Remove ```json from the response if it exists
|
||||
if (res.startsWith("```json")) {
|
||||
|
@ -168,29 +182,44 @@ async function createReviewComment(
|
|||
pull_number: number,
|
||||
comments: Array<{ body: string; path: string; line: number }>
|
||||
): Promise<void> {
|
||||
await octokit.pulls.createReview({
|
||||
owner,
|
||||
repo,
|
||||
pull_number,
|
||||
comments,
|
||||
event: "COMMENT",
|
||||
});
|
||||
try {
|
||||
await octokit.pulls.createReview({
|
||||
owner,
|
||||
repo,
|
||||
pull_number,
|
||||
comments,
|
||||
event: "COMMENT",
|
||||
});
|
||||
} catch (error) {
|
||||
console.error(error);
|
||||
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
|
||||
async function main() {
|
||||
async function main(verbose = false) {
|
||||
const prDetails = await getPRDetails();
|
||||
|
||||
if (verbose) console.log("PR Details:", prDetails);
|
||||
|
||||
let diff: string | null;
|
||||
const eventData = JSON.parse(
|
||||
readFileSync(process.env.GITHUB_EVENT_PATH ?? "", "utf8")
|
||||
);
|
||||
|
||||
if (verbose) console.log("Event Data:", eventData);
|
||||
|
||||
if (eventData.action === "opened") {
|
||||
if (verbose) console.log('Event action is "opened"');
|
||||
|
||||
diff = await getDiff(
|
||||
prDetails.owner,
|
||||
prDetails.repo,
|
||||
prDetails.pull_number
|
||||
);
|
||||
} else if (eventData.action === "synchronize") {
|
||||
if (verbose) console.log('Event action is "synchronize"');
|
||||
|
||||
const newBaseSha = eventData.before;
|
||||
const newHeadSha = eventData.after;
|
||||
|
||||
|
@ -204,12 +233,16 @@ async function main() {
|
|||
head: newHeadSha,
|
||||
});
|
||||
|
||||
if (verbose) console.log("Response:", response);
|
||||
|
||||
diff = String(response.data);
|
||||
} else {
|
||||
console.log("Unsupported event:", process.env.GITHUB_EVENT_NAME);
|
||||
return;
|
||||
}
|
||||
|
||||
if (verbose) console.log("Diff:", diff);
|
||||
|
||||
if (!diff) {
|
||||
console.log("No diff found");
|
||||
return;
|
||||
|
@ -217,18 +250,26 @@ async function main() {
|
|||
|
||||
const parsedDiff = parseDiff(diff);
|
||||
|
||||
const excludePatterns = core
|
||||
.getInput("exclude")
|
||||
if (verbose) console.log("Parsed Diff:", parsedDiff);
|
||||
|
||||
const excludePatterns = (process.env.EXCLUDE ?? core.getInput("exclude"))
|
||||
.split(",")
|
||||
.map((s) => s.trim());
|
||||
|
||||
if (verbose) console.log("Exclude Patterns:", excludePatterns);
|
||||
|
||||
const filteredDiff = parsedDiff.filter((file) => {
|
||||
return !excludePatterns.some((pattern) =>
|
||||
minimatch(file.to ?? "", pattern)
|
||||
);
|
||||
});
|
||||
|
||||
const comments = await analyzeCode(filteredDiff, prDetails);
|
||||
if (verbose) console.log("Filtered Diff:", filteredDiff);
|
||||
|
||||
const comments = await analyzeCode(filteredDiff, prDetails, verbose);
|
||||
|
||||
if (verbose) console.log("Comments:", comments);
|
||||
|
||||
if (comments.length > 0) {
|
||||
await createReviewComment(
|
||||
prDetails.owner,
|
||||
|
@ -239,7 +280,9 @@ async function main() {
|
|||
}
|
||||
}
|
||||
|
||||
main().catch((error) => {
|
||||
console.error("Error:", error);
|
||||
process.exit(1);
|
||||
});
|
||||
main((process.env.VERBOSE ?? core.getInput("VERBOSE")) === "true").catch(
|
||||
(error) => {
|
||||
console.error("Error:", error);
|
||||
process.exit(1);
|
||||
}
|
||||
);
|
||||
|
|
44
tests/main.test.ts
Normal file
44
tests/main.test.ts
Normal file
|
@ -0,0 +1,44 @@
|
|||
// test/index.test.ts
|
||||
|
||||
import { test, expect, beforeAll } from "bun:test";
|
||||
import { writeFileSync, mkdtempSync } from "fs";
|
||||
import { tmpdir } from "os";
|
||||
import { join } from "path";
|
||||
|
||||
// Set up environment variables
|
||||
beforeAll(() => {
|
||||
// Create a temporary directory
|
||||
const tempDir = mkdtempSync(join(tmpdir(), "github-action-"));
|
||||
|
||||
// Create a temporary event file
|
||||
const event = {
|
||||
action: "opened",
|
||||
number: 6, // Replace with the PR number you want to test
|
||||
repository: {
|
||||
owner: { login: "researchwiseai" },
|
||||
name: "langgraphjs-checkpoint-dynamodb",
|
||||
},
|
||||
};
|
||||
|
||||
const eventPath = join(tempDir, "event.json");
|
||||
writeFileSync(eventPath, JSON.stringify(event, null, 2));
|
||||
|
||||
process.env.GITHUB_EVENT_PATH = eventPath;
|
||||
process.env.GITHUB_EVENT_NAME = "pull_request";
|
||||
});
|
||||
|
||||
test(
|
||||
"GitHub Action runs without errors",
|
||||
async () => {
|
||||
// Import your main script
|
||||
// You may need to adjust the import path
|
||||
await import("../src/main");
|
||||
|
||||
// You can add assertions here if your script exports functions
|
||||
// For now, we just ensure it runs without throwing
|
||||
expect(true).toBe(true);
|
||||
},
|
||||
{
|
||||
timeout: 60_000,
|
||||
}
|
||||
);
|
Loading…
Add table
Add a link
Reference in a new issue