Merge branch 'main' into styleguide

Merge pull request 'Rename variables to non dom element names' (#71) from fix/rename-to-not-standard-dom-elements into main
Reviewed-on: #71
2025-03-12 18:53:16 +00:00 · 2025-03-12 18:52:30 +00:00 · 2025-03-12 19:26:07 +01:00 · 2025-03-12 19:25:11 +01:00 · 2025-03-12 19:20:51 +01:00 · 2025-03-12 18:01:55 +00:00
4 changed files with 15 additions and 12 deletions
--- a/.gitea/workflows/ci.yml
+++ b/.gitea/workflows/ci.yml
@ -10,9 +10,9 @@ jobs:
      image: "cimg/openjdk:23.0-node"
    steps:
      - name: "Checkout"
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
      - name: "Cache Gradle dependencies"
-        uses: https://github.com/actions/cache@v3
+        uses: https://github.com/actions/cache@v4
        with:
          path: |
            ~/.gradle/caches
@ -39,7 +39,7 @@ jobs:
        uses: actions/checkout@v4
      - name: Install bun
        uses: oven-sh/setup-bun@v2
-      - uses: actions/cache@v3
+      - uses: actions/cache@v4
        working-directory: ./frontend
        with:
          path: |
@ -65,7 +65,7 @@ jobs:
        uses: actions/checkout@v4
      - name: Install bun
        uses: oven-sh/setup-bun@v2
-      - uses: actions/cache@v3
+      - uses: actions/cache@v4
        working-directory: ./frontend
        with:
          path: |
@ -91,7 +91,7 @@ jobs:
        uses: actions/checkout@v4
      - name: Install bun
        uses: oven-sh/setup-bun@v2
-      - uses: actions/cache@v3
+      - uses: actions/cache@v4
        working-directory: ./frontend
        with:
          path: |
@ -99,7 +99,7 @@ jobs:
          key: ${{ runner.os }}-bun-
          restore-keys: |
            ${{ runner.os }}-bun-
-      - uses: actions/cache@v3
+      - uses: actions/cache@v4
        working-directory: ./frontend
        with:
          path: |
--- a/frontend/src/app/feature/deposit/deposit.component.ts
+++ b/frontend/src/app/feature/deposit/deposit.component.ts
@ -32,7 +32,7 @@ import gsap from 'gsap';
 })
 export class DepositComponent implements OnInit, AfterViewInit, OnDestroy, OnChanges {
  @Input() isOpen = false;
-  @Output() close = new EventEmitter<void>();
+  @Output() closeModalEmitter = new EventEmitter<void>();
  @ViewChild('modalBg') modalBg!: ElementRef;
  @ViewChild('modalCard') modalCard!: ElementRef;
  protected form!: FormGroup;
@ -110,7 +110,7 @@ export class DepositComponent implements OnInit, AfterViewInit, OnDestroy, OnCha
      this.modalAnimationService.closeModal(
        this.modalCard.nativeElement,
        this.modalBg.nativeElement,
-        () => this.close.emit()
+        () => this.closeModalEmitter.emit()
      );
    }
  }
--- a/frontend/src/app/feature/home/home.component.html
+++ b/frontend/src/app/feature/home/home.component.html
@ -73,7 +73,10 @@
        <h3 class="section-heading text-xl mb-4">Konto</h3>
        <div class="space-y-4">
          <button class="button-primary w-full py-2" (click)="openDepositModal()">Einzahlen</button>
-          <app-deposit [isOpen]="isDepositModalOpen" (close)="closeDepositModal()"></app-deposit>
+          <app-deposit
+            [isOpen]="isDepositModalOpen"
+            (closeModalEmitter)="closeDepositModal()"
+          ></app-deposit>
          <button class="bg-deep-blue-light hover:bg-deep-blue-contrast w-full py-2 rounded">
            Transaktionen
          </button>
@ -85,7 +88,7 @@

      <app-confirmation
        [successful]="isDepositSuccessful"
-        (close)="closeDepositConfirmationModal()"
+        (closeConfirmation)="closeDepositConfirmationModal()"
      ></app-confirmation>

      <div class="card p-4">
--- a/frontend/src/app/shared/components/confirmation/confirmation.component.ts
+++ b/frontend/src/app/shared/components/confirmation/confirmation.component.ts
@ -19,7 +19,7 @@ import gsap from 'gsap';
 })
 export class ConfirmationComponent implements AfterViewInit, OnDestroy {
  @Input() successful = true;
-  @Output() close = new EventEmitter<void>();
+  @Output() closeConfirmation = new EventEmitter<void>();
  @ViewChild('modalBg') modalBg!: ElementRef;
  @ViewChild('modalCard') modalCard!: ElementRef;

@ -43,7 +43,7 @@ export class ConfirmationComponent implements AfterViewInit, OnDestroy {
    this.modalAnimationService.closeModal(
      this.modalCard.nativeElement,
      this.modalBg.nativeElement,
-      () => this.close.emit()
+      () => this.closeConfirmation.emit()
    );
  }
 }
Author	SHA1	Message	Date
jleibl	cd098f717c	Merge branch 'main' into styleguide All checks were successful CI / prettier (pull_request) Successful in 46s Details CI / eslint (pull_request) Successful in 54s Details CI / Checkstyle Main (pull_request) Successful in 1m4s Details CI / test-build (pull_request) Successful in 1m3s Details	2025-03-12 18:53:16 +00:00
Jan Gleytenhoover	09fdd83192	Merge pull request 'Rename variables to non dom element names' (#71) from fix/rename-to-not-standard-dom-elements into main All checks were successful Release / Release (push) Successful in 1m44s Details Reviewed-on: #71	2025-03-12 18:52:30 +00:00
Jan Klattenhoff	8c9d7c498b	style(home): format HTML and TypeScript code for clarity All checks were successful CI / prettier (pull_request) Successful in 22s Details CI / Checkstyle Main (pull_request) Successful in 31s Details CI / eslint (pull_request) Successful in 37s Details CI / test-build (pull_request) Successful in 44s Details	2025-03-12 19:26:07 +01:00
Jan Klattenhoff	abc4277e84	refactor(deposit): rename close event emitter for clarity	2025-03-12 19:25:11 +01:00
Jan Klattenhoff	a7d98e1150	feat: rename event emitter for confirmation modal closure Some checks failed CI / prettier (pull_request) Failing after 20s Details CI / Checkstyle Main (pull_request) Successful in 31s Details CI / eslint (pull_request) Successful in 37s Details CI / test-build (pull_request) Successful in 42s Details	2025-03-12 19:20:51 +01:00
Jan Gleytenhoover	7bbabc46f3	Merge pull request 'chore(deps): update https://github.com/actions/cache action to v4' (#67) from renovate/https-github.com-actions-cache-4.x into main All checks were successful Release / Release (push) Successful in 1m8s Details Reviewed-on: #67 Reviewed-by: Jan Gleytenhoover <jan@kjan.email>	2025-03-12 18:01:55 +00:00
Jan Gleytenhoover	ba1415e8b0	Merge pull request 'chore(deps): update actions/checkout action to v4' (#64) from renovate/actions-checkout-4.x into main All checks were successful Release / Release (push) Successful in 1m10s Details Reviewed-on: #64 Reviewed-by: Jan Gleytenhoover <jan@kjan.email>	2025-03-12 17:46:48 +00:00
Renovate	f7c344faa6	chore(deps): update https://github.com/actions/cache action to v4 All checks were successful CI / eslint (pull_request) Successful in 19s Details CI / test-build (pull_request) Successful in 27s Details CI / prettier (pull_request) Successful in 57s Details CI / Checkstyle Main (pull_request) Successful in 1m20s Details	2025-03-12 16:04:42 +00:00
Renovate	910895ed82	chore(deps): update actions/checkout action to v4 All checks were successful CI / eslint (pull_request) Successful in 27s Details CI / prettier (pull_request) Successful in 40s Details CI / test-build (pull_request) Successful in 1m25s Details CI / Checkstyle Main (pull_request) Successful in 2m20s Details	2025-03-12 16:04:02 +00:00
Jan Gleytenhoover	1ad34b1ae1	Merge pull request 'chore(deps): update actions/cache action to v4' (#63) from renovate/actions-cache-4.x into main All checks were successful Release / Release (push) Successful in 1m8s Details Reviewed-on: #63 Reviewed-by: Jan Gleytenhoover <jan@kjan.email>	2025-03-12 15:43:04 +00:00
Renovate	79b83fc4c8	chore(deps): update actions/cache action to v4 All checks were successful CI / Checkstyle Main (pull_request) Successful in 46s Details CI / eslint (pull_request) Successful in 50s Details CI / prettier (pull_request) Successful in 1m3s Details CI / test-build (pull_request) Successful in 1m9s Details	2025-03-12 15:03:14 +00:00