fix: Remove constructor injection
All checks were successful
CI / Get Changed Files (pull_request) Successful in 8s
Pull Request Labeler / labeler (pull_request_target) Successful in 5s
CI / Backend Tests (pull_request) Has been skipped
CI / Checkstyle Main (pull_request) Has been skipped
Label PRs based on size / Check PR size (pull_request) Successful in 14s
CI / Docker backend validation (pull_request) Has been skipped
CI / oxlint (pull_request) Successful in 23s
CI / eslint (pull_request) Successful in 27s
CI / prettier (pull_request) Successful in 26s
CI / Docker frontend validation (pull_request) Successful in 46s
CI / test-build (pull_request) Successful in 52s
Claude PR Review / claude-code (pull_request) Successful in 1m14s
CI / Playwright (pull_request) Successful in 2m10s

This commit is contained in:
Jan K9f 2025-06-10 12:59:14 +02:00
commit 94eaf98250
17 changed files with 88 additions and 64 deletions

View file

@ -1,4 +1,11 @@
import { ChangeDetectionStrategy, Component, Input, OnChanges, SimpleChanges } from '@angular/core';
import {
ChangeDetectionStrategy,
Component,
Input,
OnChanges,
SimpleChanges,
inject,
} from '@angular/core';
import { CommonModule } from '@angular/common';
import { Card } from '@blackjack/models/blackjack.model';
import { PlayingCardComponent } from '../playing-card/playing-card.component';
@ -47,7 +54,7 @@ export class DealerHandComponent implements OnChanges {
private lastCardCount = 0;
constructor(protected gameControlsService: GameControlsService) {}
protected gameControlsService = inject(GameControlsService);
ngOnChanges(changes: SimpleChanges): void {
if (changes['cards']) {

View file

@ -1,4 +1,11 @@
import { ChangeDetectionStrategy, Component, EventEmitter, Input, Output } from '@angular/core';
import {
ChangeDetectionStrategy,
Component,
EventEmitter,
Input,
Output,
inject,
} from '@angular/core';
import { CommonModule } from '@angular/common';
import { GameState } from '@blackjack/enum/gameState';
import { Card } from '@blackjack/models/blackjack.model';
@ -69,7 +76,7 @@ export class GameControlsComponent {
protected readonly GameState = GameState;
constructor(protected gameControlsService: GameControlsService) {}
protected gameControlsService = inject(GameControlsService);
get canDoubleDown(): boolean {
return (

View file

@ -7,6 +7,7 @@ import {
Output,
signal,
SimpleChanges,
inject,
} from '@angular/core';
import { CommonModule, CurrencyPipe } from '@angular/common';
import { FormGroup, ReactiveFormsModule } from '@angular/forms';
@ -121,7 +122,9 @@ export class GameInfoComponent implements OnChanges {
betForm: FormGroup;
constructor(private bettingService: BettingService) {
private bettingService = inject(BettingService);
constructor() {
this.betForm = this.bettingService.createBetForm();
}

View file

@ -1,4 +1,11 @@
import { ChangeDetectionStrategy, Component, Input, OnChanges, SimpleChanges } from '@angular/core';
import {
ChangeDetectionStrategy,
Component,
Input,
OnChanges,
SimpleChanges,
inject,
} from '@angular/core';
import { CommonModule } from '@angular/common';
import { PlayingCardComponent } from '../playing-card/playing-card.component';
import { Card } from '@blackjack/models/blackjack.model';
@ -49,7 +56,7 @@ export class PlayerHandComponent implements OnChanges {
private lastCardCount = 0;
constructor(protected gameControlsService: GameControlsService) {}
protected gameControlsService = inject(GameControlsService);
ngOnChanges(changes: SimpleChanges): void {
if (changes['cards']) {

View file

@ -6,6 +6,7 @@ import {
Input,
OnChanges,
SimpleChanges,
inject,
} from '@angular/core';
import { CommonModule } from '@angular/common';
import { gsap } from 'gsap';
@ -58,7 +59,7 @@ export class PlayingCardComponent implements AfterViewInit, OnChanges {
@Input({ required: true }) hidden!: boolean;
@Input() isNew = false;
constructor(private elementRef: ElementRef) {}
private elementRef = inject(ElementRef);
get isRedSuit(): boolean {
return this.suit === 'HEARTS' || this.suit === 'DIAMONDS';

View file

@ -1,11 +1,11 @@
import { Injectable } from '@angular/core';
import { Injectable, inject } from '@angular/core';
import { FormBuilder, FormGroup, Validators } from '@angular/forms';
@Injectable({
providedIn: 'root',
})
export class BettingService {
constructor(private fb: FormBuilder) {}
private fb = inject(FormBuilder);
createBetForm(): FormGroup {
return this.fb.group({

View file

@ -1,4 +1,4 @@
import { Injectable } from '@angular/core';
import { Injectable, inject } from '@angular/core';
import { HttpClient } from '@angular/common/http';
import { Observable } from 'rxjs';
import { DiceDto, DiceResult } from './dice.model';
@ -10,7 +10,7 @@ import { environment } from '@environments/environment';
export class DiceService {
private apiUrl = `${environment.apiUrl}/dice`;
constructor(private http: HttpClient) {}
private http = inject(HttpClient);
rollDice(diceDto: DiceDto): Observable<DiceResult> {
return this.http.post<DiceResult>(this.apiUrl, diceDto);