refactor: immediately display login error

This commit is contained in:
Phan Huy Tran 2025-05-14 09:53:17 +02:00
commit 5f9d60d332
2 changed files with 33 additions and 31 deletions

View file

@ -1,9 +1,9 @@
import { Component } from '@angular/core';
import { FormBuilder, FormGroup, ReactiveFormsModule, Validators } from '@angular/forms';
import { Router, RouterLink } from '@angular/router';
import { LoginRequest } from '../../../model/auth/LoginRequest';
import { AuthService } from '../../../service/auth.service';
import { CommonModule } from '@angular/common';
import {Component, signal} from '@angular/core';
import {FormBuilder, FormGroup, ReactiveFormsModule, Validators} from '@angular/forms';
import {Router, RouterLink} from '@angular/router';
import {LoginRequest} from '../../../model/auth/LoginRequest';
import {AuthService} from '@service/auth.service';
import {CommonModule} from '@angular/common';
@Component({
selector: 'app-login',
@ -13,8 +13,8 @@ import { CommonModule } from '@angular/common';
})
export class LoginComponent {
loginForm: FormGroup;
errorMessage = '';
isLoading = false;
errorMessage = signal('');
isLoading = signal(false);
constructor(
private fb: FormBuilder,
@ -36,8 +36,8 @@ export class LoginComponent {
return;
}
this.isLoading = true;
this.errorMessage = '';
this.isLoading.set(true);
this.errorMessage.set('');
const loginRequest: LoginRequest = {
usernameOrEmail: this.form['usernameOrEmail'].value,
@ -49,8 +49,8 @@ export class LoginComponent {
this.router.navigate(['/home']);
},
error: (err) => {
this.isLoading = false;
this.errorMessage = err.error?.message || 'Failed to login. Please check your credentials.';
this.isLoading.set(false);
this.errorMessage.set(err.error?.message || 'Failed to login. Please check your credentials.');
},
});
}